feat(blob): blob storage coordinator + upload-policy cache#1111
Merged
Conversation
Adds the client wrapper for the BlobStorage gRPC service (direct-to-storage presigned uploads): Api/Service/Repository/Controller, an HTTP BlobUploader, the UploadTarget/UploadPolicy domain models + proto converters, error types, and DI wiring. BlobStorageController.upload() coordinates the full handshake (reserve -> PUT/POST -> complete -> poll until READY) behind one call, and getUploadPolicy() exposes the accepted MIME/size constraints. Covered by UploadPolicyTest and BlobStorageControllerTest. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Makes the shared chat FeedOperations type-aware: feed(chatType) and observeUnreadConversations(chatType) now take a required ChatType, and the sync delegate merges the CONTACT_DM and TIP_DM feeds while only applying the contact identity-drop to CONTACT_DM. Send flow consumes feed(CONTACT_DM); the contact list carries a ConversationReference instead of a raw Conversation. Session/nav rename the generic notificationUnreadCount to contactDmUnreadCount now that unread is tracked per chat type. Covered by FeedSyncCombinedFeedTest. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Adds the app-layer BlobStorageCoordinator (new :apps:flipcash:shared:blob module) wrapping BlobStorageController. It owns a DataStore-backed upload-policy cache, exposes policy as a self-refreshing Flow (TTL + version invalidation), and offers preloadPolicy()/upload(). The session controller preloads the policy once the user is registered so photo selection can filter/validate locally without a round-trip. Covered by BlobStorageCoordinatorTest. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: feature
bmc08gt
added a commit
that referenced
this pull request
Jul 21, 2026
* feat(opencode): bring back Kind.Tip on OpenCodePayload Ports the legacy CodePayload tip layout onto OpenCodePayload. The payload value becomes polymorphic (PayloadValue): Cash/MultiMintCash carry a Fiat as before, Tip carries a Username. Fiat now implements PayloadValue, so existing call sites are unaffected and the Cash/MultiMintCash wire format is unchanged. Tip encoding follows the shipped legacy scheme: the username is written at OFFSET_USERNAME and short usernames are padded with '.' + base64(SHA256(username)) out to 15 bytes; decode recovers the username by stripping at the '.' delimiter. GrabBillTransactor rejects Tip as non-grabbable; CodeScanDelegate routes Tip off the cash path (tip-scan handling is a follow-up). Covered by OpenCodePayloadTests tip round-trips. Signed-off-by: Brandon McAnsh <git@bmcreations.dev> * test(session): fix RealSessionController construction after blobStorageCoordinator RealSessionController gained a blobStorageCoordinator constructor param (#1111) but these two direct-construction tests were not updated, leaving the session unit-test source uncompilable on trunk. Pass a relaxed mock like the other coordinators. Signed-off-by: Brandon McAnsh <git@bmcreations.dev> --------- Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 3/5 — base:
feat/type-aware-dm-feedApp-layer coordinator over the services blob client (from #1109), following the Coordinator pattern used across the app so ViewModels depend on the coordinator rather than the controller.
What
:apps:flipcash:shared:blobmodule withBlobStorageCoordinator.policyas a self-refreshingFlow(TTL + version invalidation), pluspreloadPolicy()andupload().Tests
BlobStorageCoordinatorTest(TTL, version invalidation, refresh dedupe).